RFR: 8301997: Move method resolution information out of the cpCache [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Oct 19 20:00:07 UTC 2023
On Wed, 18 Oct 2023 08:03:38 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed some comments and relocated code
>
> src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp line 2314:
>
>> 2312: CALL_VM(InterpreterRuntime::resolve_from_cache(THREAD, (Bytecodes::Code)opcode),
>> 2313: handle_exception);
>> 2314: entry = cp->resolved_method_entry_at(index);
>
> Do you actually need to lookup the entry again? I'm not really sure why the old code needed to do so.
This is probably unnecessary. I will try removing it and see what the test results look like.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1366042191
More information about the hotspot-dev
mailing list