RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v3]

Julian Waters jwaters at openjdk.org
Thu Oct 26 04:29:29 UTC 2023


On Thu, 26 Oct 2023 02:56:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > moved out of the os::win32
> 
> This doesn't seem to add any value. Seemed fine to me in os::win32 versus os class.

I noticed that the method wasn't used anywhere outside of os_windows.cpp, and since I was rewriting it to be noreturn, I figured that a little refactoring of scope (from os::win32 to os_windows.cpp file scope) could help here

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16303#issuecomment-1780395197


More information about the hotspot-dev mailing list