RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v3]

[David Holmes]

On Thu, 26 Oct 2023 04:26:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> I figured that a little refactoring of scope (from os::win32 to os_windows.cpp file scope) could help here

The very loose, not well followed, historical convention here is that the Windows specific os class contains the methods defined by os.hpp, while the implementation details go into the os::win32 class. In many cases the choice is somewhat arbitrary, but there should still be a good reason to move something around. Unnecessary refactoring just makes the PR harder to understand.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16303#issuecomment-1782270410