RFR: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

Gui Cao gcao at openjdk.org
Fri Oct 27 06:58:44 UTC 2023


Hi, The current test_bit assembly function needs to accept a temporary register because it needs one if it goes to the andi else branch. However, in this case we can actually avoid calling andi and accomplish the same thing by logically shifting to the right and testing the lowest bit. The advantage is that it makes the test_bit function much simpler. Also, to reduce the number of instructions in a given case (consider the mv function), mv actually calls the li function, which generates more than one instruction when the parameter imm exceeds the 32-bit range.
https://github.com/openjdk/jdk/blob/9123961aaa47aa58ec436640590d2cceedb8cbb1/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L804-L840

### Testing:
qemu 8.1.50:
- [ ] Tier1 tests (fastdebug)
- [ ] Tier2 tests (release)
- [ ] Tier3 tests (release)

-------------

Commit messages:
 - 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

Changes: https://git.openjdk.org/jdk/pull/16391/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16391&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8318953
  Stats: 10 lines in 3 files changed: 6 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/16391.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16391/head:pull/16391

PR: https://git.openjdk.org/jdk/pull/16391


More information about the hotspot-dev mailing list