RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v5]

[Julian Waters]

On Mon, 30 Oct 2023 07:40:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert to exit_code in os_windows.cpp
>
> src/hotspot/os/windows/os_windows.cpp line 515:
> 
>> 513: // The handler passed to _beginthreadex().
>> 514: // Called with the associated Thread* as the argument.
>> 515: static unsigned __stdcall thread_native_entry(void*);
> 
> This forward declaration is being added for a function that is defined a few lines later, with no intervening
> references.  That seems pointless.

I understand, but what about the useful (at least to me) comment? Should I move it to the definition of the method?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16303#discussion_r1376167186