RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v5]

[Kim Barrett]

On Mon, 30 Oct 2023 12:53:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 515:
>> 
>>> 513: // The handler passed to _beginthreadex().
>>> 514: // Called with the associated Thread* as the argument.
>>> 515: static unsigned __stdcall thread_native_entry(void*);
>> 
>> This forward declaration is being added for a function that is defined a few lines later, with no intervening
>> references.  That seems pointless.
>
> I understand, but what about the useful (at least to me) comment? Should I move it to the definition of the method?

Sure, move the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16303#discussion_r1378124137