RFR: 8315652: RISC-V: Features string uses wrong separator for jtreg

Fei Yang fyang at openjdk.org
Thu Sep 7 07:59:50 UTC 2023


On Wed, 6 Sep 2023 06:14:07 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi, please consider.
> 
> As described in jbs, this handles both cases with a rough solution by having two strings.
> Meaning we get e.g. 'v' as a separate feature from CPUInfo, but we still get the pretty string in e.g. hs_err.
> 
> Tested tier1 on qemu rv.

Hi, I have a small question about the JBS description. Where does the comma in the string we are regexping comes from if we use plain space here?
I am also wondering if we could do the separation for the original `_features_string`. This would help elimnate changes to the shared code. I guess it might not be a big issue for other places.

src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 162:

> 160: 
> 161:   _features_string = os::strdup(buf);
> 162:   _parsable_features_string = os::strdup(buf);

Shouldn't this be `buf_pfs` instead of `buf`?

-------------

Changes requested by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15579#pullrequestreview-1614780830
PR Review Comment: https://git.openjdk.org/jdk/pull/15579#discussion_r1318212928


More information about the hotspot-dev mailing list