RFR: 8315652: RISC-V: Features string uses wrong separator for jtreg

Robbin Ehn rehn at openjdk.org
Thu Sep 7 08:39:40 UTC 2023


On Thu, 7 Sep 2023 07:41:43 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> As described in jbs, this handles both cases with a rough solution by having two strings.
>> Meaning we get e.g. 'v' as a separate feature from CPUInfo, but we still get the pretty string in e.g. hs_err.
>> 
>> Tested tier1 on qemu rv.
>
> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 162:
> 
>> 160: 
>> 161:   _features_string = os::strdup(buf);
>> 162:   _parsable_features_string = os::strdup(buf);
> 
> Shouldn't this be `buf_pfs` instead of `buf`?

Yes, this looks wrong. I'll investigate way this was working in testing. It seem like it should not have....

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15579#discussion_r1318278253


More information about the hotspot-dev mailing list