RFR: 8315652: RISC-V: Features string uses wrong separator for jtreg [v2]

Robbin Ehn rehn at openjdk.org
Thu Sep 7 12:29:04 UTC 2023


On Thu, 7 Sep 2023 08:36:46 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 162:
>> 
>>> 160: 
>>> 161:   _features_string = os::strdup(buf);
>>> 162:   _parsable_features_string = os::strdup(buf);
>> 
>> Shouldn't this be `buf_pfs` instead of `buf`?
>
> Yes, this looks wrong. I'll investigate way this was working in testing. It seem like it should not have....

Yes, this was not working at all. I found the issue in my testing. Good catch! Thanks alot!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15579#discussion_r1318527157


More information about the hotspot-dev mailing list