RFR: 8316581: Improve performance of Symbol::print_value_on() [v2]

Thomas Schatzl tschatzl at openjdk.org
Thu Sep 21 08:30:56 UTC 2023


On Thu, 21 Sep 2023 02:51:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   coleen review
>
> src/hotspot/share/oops/symbol.cpp line 393:
> 
>> 391: void Symbol::print_value_on(outputStream* st) const {
>> 392:   st->print_raw("'", 1);
>> 393:   static_assert(sizeof(u1) == sizeof(char), "must be");
> 
> Given the whole class assumes u1 and char equivalence this assertion seems out of place here.

I removed the static assert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15838#discussion_r1332674523


More information about the hotspot-dev mailing list