RFR: 8316581: Improve performance of Symbol::print_value_on() [v2]

Thomas Schatzl tschatzl at openjdk.org
Thu Sep 21 14:49:52 UTC 2023


On Thu, 21 Sep 2023 03:00:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   coleen review
>
> This seems okay on the surface but raises some questions for me. Why do we have `print_value_on` and `print_symbol_on`? I get the sense that the former is somehow lower-level and potentially unsafe - which suggests that UL should not be using it in general! I could not find the original review thread for when `print_value_on` was added to answer this question, nor answer why the loop was used.
> 
> Thanks.

Thanks @dholmes-ora @shipilev @coleenp for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15838#issuecomment-1729734169


More information about the hotspot-dev mailing list