RFR: 8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer

[Axel Boldt-Christmas]

On Thu, 4 Apr 2024 08:36:37 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This changeset updates an assert in G1's interpreter x86 post-barrier logic so that it refers to the right queue (`G1DirtyCardQueue` rather than pre-barrier's `SATBMarkQueue`) and moves the assert closer to the logic that exploits it.
> 
> Thanks to Kim Barrett for reporting the issue and suggesting the fix.
> 
> **Testing**: built on windows-x64, linux-x64, and macosx-x64.

Looks good. 

It is a little strange to me to use `pointer sized`, `sizeof(intptr_t)` and `wordSize` this interchangeably. 

Side note: The assert that used the correct queue type (in `generate_c1_pre_barrier_runtime_stub`) now have different styles w.r.t. having the static assert at the top of the function vs. next to the specific logic.

-------------

Marked as reviewed by aboldtch (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18616#pullrequestreview-1979288356