RFR: 8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer

Thu Apr 4 09:37:09 UTC 2024

On Thu, 4 Apr 2024 09:22:23 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> Looks good.

Thanks for reviewing, Axel!

> It is a little strange to me to use `pointer sized`, `sizeof(intptr_t)` and `wordSize` this interchangeably.
> 
> Side note: The assert that used the correct queue type (in `generate_c1_pre_barrier_runtime_stub`) now have different styles w.r.t. having the static assert at the top of the function vs. next to the specific logic.

I agree, the whole `g1BarrierSetAssembler_x86.cpp` file would probably benefit from some refactoring to enforce consistency across different barrier implementations. But I think it would be best to postpone that cleanup to after [JDK-8322295](https://bugs.openjdk.org/browse/JDK-8322295) is implemented.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18616#issuecomment-2036679814