RFR: 8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer

[Kim Barrett]

On Thu, 4 Apr 2024 08:36:37 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This changeset updates an assert in G1's interpreter x86 post-barrier logic so that it refers to the right queue (`G1DirtyCardQueue` rather than pre-barrier's `SATBMarkQueue`) and moves the assert closer to the logic that exploits it.
> 
> Thanks to Kim Barrett for reporting the issue and suggesting the fix.
> 
> **Testing**: built on windows-x64, linux-x64, and macosx-x64.

Looks good.

> > Looks good.
> 
> Thanks for reviewing, Axel!
> 
> I agree, the whole `g1BarrierSetAssembler_x86.cpp` file would probably benefit from some refactoring to enforce consistency across different barrier implementations. But I think it would be best to postpone that cleanup to after [JDK-8322295](https://bugs.openjdk.org/browse/JDK-8322295) is implemented.

Given that I'm actively prototyping another change on top of the late barrier work, I'd really appreciate not having
the g1BarrierSetAssembler files unnecessarily refactored any more for now.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18616#pullrequestreview-1980330434
PR Comment: https://git.openjdk.org/jdk/pull/18616#issuecomment-2037546689