RFR: 8180450: secondary_super_cache does not scale well [v14]

[Andrew Haley]

On Fri, 12 Apr 2024 18:01:22 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8180450: secondary_super_cache does not scale well
>
> src/hotspot/cpu/x86/stubRoutines_x86.hpp line 41:
> 
>> 39:   // Windows have more code to save/restore registers
>> 40:   _compiler_stubs_code_size     = 20000 LP64_ONLY(+39000) WINDOWS_ONLY(+2000),
>> 41:   _final_stubs_code_size        = 10000 LP64_ONLY(+20000) WINDOWS_ONLY(+2000) ZGC_ONLY(+24000)
> 
> Do we still need it after you moved code to compiler stubs section?

It's a bug in that the 20000 byte figure is an underestimate for what zgc stubs need. I could take it out for this patch, I guess, but it'd still be a bug.

> src/hotspot/cpu/x86/vm_version_x86.cpp line 1786:
> 
>> 1784:       }
>> 1785:       FLAG_SET_DEFAULT(UseSecondarySupersTable, false);
>> 1786:     }
> 
> No need this with other changes I suggest.

Never mind, it's gone.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18309#discussion_r1565723607
PR Review Comment: https://git.openjdk.org/jdk/pull/18309#discussion_r1565724331