RFR: 8180450: secondary_super_cache does not scale well [v14]

Mon Apr 15 21:03:03 UTC 2024

On Mon, 15 Apr 2024 12:36:44 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubRoutines_x86.hpp line 41:
>> 
>>> 39:   // Windows have more code to save/restore registers
>>> 40:   _compiler_stubs_code_size     = 20000 LP64_ONLY(+39000) WINDOWS_ONLY(+2000),
>>> 41:   _final_stubs_code_size        = 10000 LP64_ONLY(+20000) WINDOWS_ONLY(+2000) ZGC_ONLY(+24000)
>> 
>> Do we still need it after you moved code to compiler stubs section?
>
> It's a bug in that the 20000 byte figure is an underestimate for what zgc stubs need. I could take it out for this patch, I guess, but it'd still be a bug.

IMO it's better to handle it separately. It'll make it easier to backport the fix if needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18309#discussion_r1566432954