RFR: 8329088: Stack chunk thawing races with concurrent GC stack iteration [v3]

[Erik Österlund]

On Fri, 12 Apr 2024 15:16:33 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Partricio fixes
>
> src/hotspot/share/oops/stackChunkOop.inline.hpp line 135:
> 
>> 133: 
>> 134: inline bool stackChunkOopDesc::is_empty() const {
>> 135:   assert(sp() <= stack_size(), "");
> 
> Maybe keep assert(sp() <= bottom(), "")?

Fixed!

> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 662:
> 
>> 660: 
>> 661: void FreezeBase::freeze_fast_copy(stackChunkOop chunk, int chunk_start_sp CONT_JFR_ONLY(COMMA bool chunk_is_allocated)) {
>> 662:   assert(chunk != nullptr, "");
> 
> Isn't this assert still valid?

It is. Fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18643#discussion_r1567051769
PR Review Comment: https://git.openjdk.org/jdk/pull/18643#discussion_r1567051537