RFR: 8329088: Stack chunk thawing races with concurrent GC stack iteration [v2]
Erik Österlund
eosterlund at openjdk.org
Mon Apr 22 09:42:42 UTC 2024
On Wed, 17 Apr 2024 00:34:17 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> I currently have an assert that checks that you shouldn't be asking for the argsize() if the chunk is empty, because it is so error prone. I think I'd like to keep the assert though - it was quite useful.
>
> We should be okay since _cont.argsize gets it from the ContinuationEntry. I tested it a bit and we would also need to update _fast_freeze_size to be cont_size() in the chunk empty case before calling freeze_fast_copy() otherwise we hit an assert there. But I can do this in another RFR if you want.
That would be great, thank you!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18643#discussion_r1574450463
More information about the hotspot-dev
mailing list