RFR: 8330156: RISC-V: Range check auipc + signed 12 imm instruction [v4]
Fei Yang
fyang at openjdk.org
Thu Apr 18 12:17:02 UTC 2024
On Thu, 18 Apr 2024 10:52:20 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi please consider!
>>
>> Today we check if the distance is a signed 32.
>> As the second instruction have sign bit + 11 bits the, max of such pair is shorter.
>>
>> Sanity tested
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename
TBH, I don't really like this new name `is_valid_auipc_offset` which I think could be misleading. Because it's not an offset for solely `auipc`. I prefer names like `is_valid_32bit_offset` or `riscv_insn_valid_32bit_offset` which is similar to the one in linux. But I will let you guys decide :-)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18755#issuecomment-2063720818
More information about the hotspot-dev
mailing list