RFR: 8330578: The VM creates instance of abstract class VirtualMachineError [v5]

[Coleen Phillimore]

On Mon, 22 Apr 2024 07:35:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'master' into vme
>>  - Throw preallocated SOE object.
>>  - We don't need to link and initialize VirtualMachineError class because the lines just below it that link and initialize and create an instance of StackOverflowError will do that, since VME is a subclass of SOE.
>>  - Remove newline
>>  - 8330578: The VM creates instance of abstract class VirtualMachineError
>
> src/hotspot/share/utilities/exceptions.cpp line 124:
> 
>> 122:                         exc_value, message ? ": " : "", message ? message : "",
>> 123:                         p2i(h_exception()), file, line, p2i(thread),
>> 124:                         Universe::null_ptr_exception_instance()->print_value_string());
> 
> I think this will look odd. Throwing `InternalError` may be more appropriate.

Unfortunately, we don't pre-allocate an instance of InternalError.

    // We do not care what kind of exception we get for a thread which
    // is compiling.  We just install a dummy exception object
    thread->set_pending_exception(Universe::null_ptr_exception_instance(), file, line);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18847#discussion_r1574601083