RFR: 8330578: The VM creates instance of abstract class VirtualMachineError [v5]

[Coleen Phillimore]

On Mon, 22 Apr 2024 11:30:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/utilities/exceptions.cpp line 124:
>> 
>>> 122:                         exc_value, message ? ": " : "", message ? message : "",
>>> 123:                         p2i(h_exception()), file, line, p2i(thread),
>>> 124:                         Universe::null_ptr_exception_instance()->print_value_string());
>> 
>> I think this will look odd. Throwing `InternalError` may be more appropriate.
>
> Unfortunately, we don't pre-allocate an instance of InternalError.
> 
>     // We do not care what kind of exception we get for a thread which
>     // is compiling.  We just install a dummy exception object
>     thread->set_pending_exception(Universe::null_ptr_exception_instance(), file, line);

I have to put all this code back to create, store for CDS and use InternalError.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18847#discussion_r1574605176