RFR: 8330578: The VM creates instance of abstract class VirtualMachineError [v5]

[Ioi Lam]

On Mon, 22 Apr 2024 11:34:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Unfortunately, we don't pre-allocate an instance of InternalError.
>> 
>>     // We do not care what kind of exception we get for a thread which
>>     // is compiling.  We just install a dummy exception object
>>     thread->set_pending_exception(Universe::null_ptr_exception_instance(), file, line);
>
> I have to put all this code back to create, store for CDS and use InternalError.

> Unfortunately, we don't pre-allocate an instance of InternalError.

But you just need to replaced the lines that you deleted for VirtualMachineError with InternalError. I think that would be cleaner than having to explain a weird behavior in comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18847#discussion_r1574969936