RFR: 8330578: The VM creates instance of abstract class VirtualMachineError [v7]

[Coleen Phillimore]

On Mon, 22 Apr 2024 21:58:15 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - restore exceptions.cpp comment
>>  - Restore VirtualMemoryError as InternalError - a nonabstract class
>
> src/hotspot/share/classfile/verifier.cpp line 258:
> 
>> 256:         // to infinitely recurse when we try to initialize the exception.
>> 257:         // So bail out here by throwing the preallocated VM error.
>> 258:         THROW_OOP_(Universe::class_init_stack_overflow_error(), false);
> 
> Should this be InternalError now?  That seems better than StackOverflow.

Technically it's a stack overflow.  I don't think it's a reachable code path so it doesn't really matter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18847#discussion_r1575423616