RFR: 8312132: Add tracking of multiple address spaces in NMT [v49]

Johan Sjölen jsjolen at openjdk.org
Thu Apr 25 10:37:34 UTC 2024


On Tue, 23 Apr 2024 20:31:52 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move TreapNode into Treap
>
> src/hotspot/share/nmt/memTracker.hpp line 172:
> 
>> 170:   static inline MemoryFileTracker::MemoryFile* register_device(const char* descriptive_name) {
>> 171:     assert_post_init();
>> 172:     if (!enabled()) return nullptr;
> 
> Could we push `assert_post_init()` into `enabled()` ?

That's a discussion that should take place in its own PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1579253198


More information about the hotspot-dev mailing list