RFR: 8312132: Add tracking of multiple address spaces in NMT [v49]

Gerard Ziemski gziemski at openjdk.org
Sat Apr 27 13:16:14 UTC 2024


On Thu, 25 Apr 2024 10:34:50 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/nmt/memTracker.hpp line 172:
>> 
>>> 170:   static inline MemoryFileTracker::MemoryFile* register_device(const char* descriptive_name) {
>>> 171:     assert_post_init();
>>> 172:     if (!enabled()) return nullptr;
>> 
>> Could we push `assert_post_init()` into `enabled()` ?
>
> That's a discussion that should take place in its own PR.

I see 16 instances of the same patter:


    assert_post_init();
    if (!enabled()) return


`in memTracker.hpp` so it's local and isolated to `MemTracker` class. I didn't think this would be controversial/big deal to warrant its own PR?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1581829130


More information about the hotspot-dev mailing list