RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v7]
kuaiwei
duke at openjdk.org
Mon Apr 29 02:58:17 UTC 2024
On Tue, 16 Apr 2024 14:06:14 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix arm build error
>
> Argh, I found it. It happens because C2 calls `masm->offset()` from `PhaseOutput::fill_buffer()` after every node is emitted. So that trick isn't going to work.
>
> It was worth a try, but given that C2 expects offset() to be correct after every node, I think we're stuck. Maybe the last idea you had is the best possible without C2 tinkering.
@theRealAph Could you help review this PR? Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18467#issuecomment-2081807917
More information about the hotspot-dev
mailing list