RFR: 8312132: Add tracking of multiple address spaces in NMT [v46]

Johan Sjölen jsjolen at openjdk.org
Mon Apr 29 08:56:18 UTC 2024


On Tue, 23 Apr 2024 12:45:18 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove faulty condition after removing merging
>>  - Add failing test case
>
> src/hotspot/share/nmt/nmtMemoryFileTracker.cpp line 43:
> 
>> 41: }
>> 42: 
>> 43: void MemoryFileTracker::allocate_memory(MemoryFile* device, size_t offset,
> 
> check/assert `device == nullptr`.

This kind of check is in  `MemTracker`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1582727559


More information about the hotspot-dev mailing list