RFR: 8312132: Add tracking of multiple address spaces in NMT [v46]

Thomas Stuefe stuefe at openjdk.org
Tue Apr 30 06:23:13 UTC 2024


On Mon, 29 Apr 2024 08:51:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> How about making your own index type? Something that clearly distinguishes it from sizes. Can be a simple typedef.
>> 
>> I think address would be wrong. But size_t is also feeling off. I know we use size_t in other places as index or offset, but it still throws me off, I think of size_t as a size, not an offset.
>
> I'm fine with `typedef`:ing `size_t`, but I'd like a naming suggestion from you if that's alright. Naming isn't my strong suit and I'd prefer only doing the rename once :).

If the type is defined within VMATree scope, it can be anything short and succinct, e.g. 
`VMATree::position_t`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1584188364


More information about the hotspot-dev mailing list