RFR: 8337797: Additional ExternalAddress cleanup

[Vladimir Kozlov]

On Mon, 5 Aug 2024 18:11:55 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> While working on [JDK-8337519](https://bugs.openjdk.org/browse/JDK-8337519) I noticed few ExternalAddress cases I missed in [JDK-8337396](https://bugs.openjdk.org/browse/JDK-8337396) changes.
> 
> I also added asserts on x86 to catch using ExternalAddress for jumps and calls instructions and caught few additional cases (Windows and arraycopy cases).
> 
> Tested tier1-5,hs-stress,hs-comp

src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 845:

> 843:                         Label& L_ok) {
> 844:   Label L_fail;
> 845:   __ lea(temp_reg, AddressLiteral(code_start, relocInfo::none));

No need relocation here. This check code is generated  for i2c adapters which we don't relocate - we put them into reserved code buffer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20470#discussion_r1704476694