RFR: 8337797: Additional ExternalAddress cleanup [v2]

[Andrew Dinn]

On Tue, 6 Aug 2024 04:48:03 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> While working on [JDK-8337519](https://bugs.openjdk.org/browse/JDK-8337519) I noticed few ExternalAddress cases I missed in [JDK-8337396](https://bugs.openjdk.org/browse/JDK-8337396) changes.
>> 
>> I also added asserts on x86 to catch using ExternalAddress for jumps and calls instructions and caught few additional cases (Windows and arraycopy cases).
>> 
>> Tested tier1-5,hs-stress,hs-comp
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   riscv update

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 218:

> 216:   __ lea(end_from, Address(from, count, sf, 0));
> 217:   if (NOLp == nullptr) {
> 218:     RuntimeAddress no_overlap(no_overlap_target);

I think this is actually a jump within the same buffer. Can we use an AddressLiteral here with reloc_none and rely on this being encoded with a PC-relative jump?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20470#discussion_r1705576489