RFR: 8337797: Additional ExternalAddress cleanup [v2]

[Vladimir Kozlov]

On Tue, 6 Aug 2024 13:48:57 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   riscv update
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 218:
> 
>> 216:   __ lea(end_from, Address(from, count, sf, 0));
>> 217:   if (NOLp == nullptr) {
>> 218:     RuntimeAddress no_overlap(no_overlap_target);
> 
> I think this is actually a jump within the same buffer. Can we use an AddressLiteral here with reloc_none and rely on this being encoded with a PC-relative jump?

`relic_none` is treated as unreachable and will force using lea():
https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/assembler_x86.cpp#L12915

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20470#discussion_r1705853432