RFR: 8337797: Additional ExternalAddress cleanup [v2]

[Tobias Hartmann]

On Tue, 6 Aug 2024 04:48:03 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> While working on [JDK-8337519](https://bugs.openjdk.org/browse/JDK-8337519) I noticed few ExternalAddress cases I missed in [JDK-8337396](https://bugs.openjdk.org/browse/JDK-8337396) changes.
>> 
>> I also added asserts on x86 to catch using ExternalAddress for jumps and calls instructions and caught few additional cases (Windows and arraycopy cases).
>> 
>> Tested tier1-5,hs-stress,hs-comp
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   riscv update

Looks good to me too.

src/hotspot/cpu/x86/macroAssembler_x86.cpp line 2332:

> 2330: void MacroAssembler::jump(AddressLiteral dst, Register rscratch) {
> 2331:   assert(rscratch != noreg || always_reachable(dst), "missing");
> 2332:   assert(!dst.rspec().reloc()->is_data(), "should not use ExternalAddress for jump");

Should these assert be added for other platforms as well?

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20470#pullrequestreview-2229681432
PR Review Comment: https://git.openjdk.org/jdk/pull/20470#discussion_r1711063820