RFR: 8337797: Additional ExternalAddress cleanup [v2]

[Vladimir Kozlov]

On Fri, 9 Aug 2024 08:43:24 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   riscv update
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 2332:
> 
>> 2330: void MacroAssembler::jump(AddressLiteral dst, Register rscratch) {
>> 2331:   assert(rscratch != noreg || always_reachable(dst), "missing");
>> 2332:   assert(!dst.rspec().reloc()->is_data(), "should not use ExternalAddress for jump");
> 
> Should these assert be added for other platforms as well?

It is not easy for me to find instructions in other ports into which to add such assert. For example, aarch64 use several instructions to load address for branch. I hope engineers responsible for ports will add such assert where it is needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20470#discussion_r1711820620