RFR: 8327652: S390x: Implements SLP support [v7]

Amit Kumar amitkumar at openjdk.org
Tue Aug 20 16:31:46 UTC 2024


On Tue, 26 Mar 2024 15:10:37 GMT, Sidraya Jayagond <sjayagond at openjdk.org> wrote:

>> This PR Adds SIMD support on s390x.
>
> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
> 
>   PopCountVI supported by z14 onwards.

There is another problem, Build is broken with these changes. 

If we just pull the changes from this PR and do a build, this is the error I was getting: 

/home/amit/jdk/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java warning: [dangling-doc-comments] documentation comment is not attached to any declaration


Then I thought maybe any dependency is causing issue and might have pick the latest changes; So I rebased it with head stream and was welcomed by this error: 

* For target hotspot_variant-server_libjvm_objs_ad_s390.o:
/home/amit/jdk/src/hotspot/cpu/s390/s390.ad: In member function 'uint MachSpillCopyNode::implementation(C2_MacroAssembler*, PhaseRegAlloc*, bool, outputStream*) const':
/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1153:11: error: 'cbuf' was not declared in this scope
 1153 |       if (cbuf) {
      |           ^~~~
/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1160:11: error: 'cbuf' was not declared in this scope
 1160 |       if (cbuf) {
      |           ^~~~
/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1167:11: error: 'cbuf' was not declared in this scope
 1167 |       if (cbuf) {
      |           ^~~~
/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1175:11: error: 'cbuf' was not declared in this scope
 1175 |       if (cbuf) {
      |           ^~~~


Weird thing is that initially it was building fine with all of the VMs (fastdebug, slowdebug, release).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18162#issuecomment-2299265908


More information about the hotspot-dev mailing list