RFR: 8327652: S390x: Implements SLP support [v7]

[Lutz Schmidt]

On Tue, 26 Mar 2024 15:10:37 GMT, Sidraya Jayagond <sjayagond at openjdk.org> wrote:

>> This PR Adds SIMD support on s390x.
>
> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
> 
>   PopCountVI supported by z14 onwards.

Hi Amit,

the function prototype now reads
uint MachSpillCopyNode::implementation(C2_MacroAssembler *masm, PhaseRegAlloc *ra_, bool do_size, outputStream *os) const {

There is no cbuf argument anymore.

Side note: I would prefer to see
If (masm != nullprt)
Instead of
If (masm)

Thanks,
Lutz

From: Amit Kumar ***@***.***>
Date: Tuesday, 20. August 2024 at 18:26
To: openjdk/jdk ***@***.***>
Cc: Schmidt, Lutz ***@***.***>, Mention ***@***.***>
Subject: Re: [openjdk/jdk] 8327652: S390x: Implements SLP support (PR #18162)

There is another problem, Build is broken with these changes.

If we just pull the changes from this PR and do a build, this is the error I was getting:

/home/amit/jdk/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java warning: [dangling-doc-comments] documentation comment is not attached to any declaration

Then I thought maybe any dependency is causing issue and might have pick the latest changes; So I rebased it with head stream and was welcomed by this error:

* For target hotspot_variant-server_libjvm_objs_ad_s390.o:

/home/amit/jdk/src/hotspot/cpu/s390/s390.ad: In member function 'uint MachSpillCopyNode::implementation(C2_MacroAssembler*, PhaseRegAlloc*, bool, outputStream*) const':

/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1153:11: error: 'cbuf' was not declared in this scope

 1153 |       if (cbuf) {

      |           ^~~~

/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1160:11: error: 'cbuf' was not declared in this scope

 1160 |       if (cbuf) {

      |           ^~~~

/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1167:11: error: 'cbuf' was not declared in this scope

 1167 |       if (cbuf) {

      |           ^~~~

/home/amit/jdk/src/hotspot/cpu/s390/s390.ad:1175:11: error: 'cbuf' was not declared in this scope

 1175 |       if (cbuf) {

      |           ^~~~

Weird thing is that initially it was building fine with all of the VMs (fastdebug, slowdebug, release).

—
Reply to this email directly, view it on GitHub<https://github.com/openjdk/jdk/pull/18162#issuecomment-2299265908>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ6PCMMURK7MZVQYPHXR4STZSNUZ7AVCNFSM6AAAAABEMGVF5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGI3DKOJQHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18162#issuecomment-2299389036