RFR: 8339030: frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument

[David Holmes]

On Tue, 27 Aug 2024 00:19:04 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Method
> frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument
> 
> it usually is called with nullptr as second arg except
> JavaThread::trace_frames()
> where it is called with this.
> 
> It seems that thread has never been used since 2007 so makes sense just to get rid of it.
> 
> Tested building all builds available in CI and running tier13

Looks like it has been unused since [JDK-4894843](https://bugs.openjdk.org/browse/JDK-4894843) was integrated back in 2003. :)

Thanks for the clean up. One nit below.

src/hotspot/share/runtime/frame.hpp line 437:

> 435:  public:
> 436:   void print_value() const { print_value_on(tty); }
> 437:   void print_value_on(outputStream *st) const;

Nit: the * should be at the end of `outputStream` not the start of `st`.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20721#pullrequestreview-2261953035
PR Review Comment: https://git.openjdk.org/jdk/pull/20721#discussion_r1732025523