RFR: 8339030: frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument [v2]

Leonid Mesnik lmesnik at openjdk.org
Tue Aug 27 17:14:38 UTC 2024


On Tue, 27 Aug 2024 02:08:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed identation
>
> src/hotspot/share/runtime/frame.hpp line 437:
> 
>> 435:  public:
>> 436:   void print_value() const { print_value_on(tty); }
>> 437:   void print_value_on(outputStream *st) const;
> 
> Nit: the * should be at the end of `outputStream` not the start of `st`.

Thanks! I missed that IDE "helped" me here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20721#discussion_r1733250525


More information about the hotspot-dev mailing list