RFR: 8345351: RISC-V: Rename macro-assembler routine cmpxchg_weak to weak_cmpxchg

Hamlin Li mli at openjdk.org
Tue Dec 3 09:23:39 UTC 2024


On Tue, 3 Dec 2024 01:31:18 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, Please consider this trivial change.
> 
> We have macro-assembler routine names like `cmpxchg_narrow_value` and `weak_cmpxchg_narrow_value`. And we also have `cmpxchg` and `cmpxchg_weak`. We should rename `MacroAssembler::cmpxchg_weak` to `MacroAssembler::weak_cmpxchg` for consistency in naming with friends. This will also be consistent with names like `weakCompareAndSwapI`, `weakCompareAndSwapL` in AD files.
> 
> - [x] hotspot:tier1 test on linux-riscv64 platform.

Make sense, thanks!

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22505#pullrequestreview-2475040137


More information about the hotspot-dev mailing list