RFR: 8345351: RISC-V: Rename macro-assembler routine cmpxchg_weak to weak_cmpxchg

Fei Yang fyang at openjdk.org
Tue Dec 3 10:20:37 UTC 2024


On Tue, 3 Dec 2024 06:30:41 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, Please consider this trivial change.
>> 
>> We have macro-assembler routine names like `cmpxchg_narrow_value` and `weak_cmpxchg_narrow_value`. And we also have `cmpxchg` and `cmpxchg_weak`. We should rename `MacroAssembler::cmpxchg_weak` to `MacroAssembler::weak_cmpxchg` for consistency in naming with friends. This will also be consistent with names like `weakCompareAndSwapI`, `weakCompareAndSwapL` in AD files.
>> 
>> - [x] hotspot:tier1 test on linux-riscv64 platform.
>
> Thanks!

@robehn @Hamlin-Li : Thanks for having a look!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22505#issuecomment-2514125755


More information about the hotspot-dev mailing list