RFR: 8345179: RISC-V: Add gtests for weak cmpxchg [v5]

[Hamlin Li]

On Tue, 3 Dec 2024 07:34:04 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> This adds tests of aligned weak narrow cmpxchg.
>> 
>> [ RUN      ] RiscV.cmpxchg_weak_int16_lr_sc_vm
>> [       OK ] RiscV.cmpxchg_weak_int16_lr_sc_vm (2 ms)
>> [ RUN      ] RiscV.cmpxchg_weak_int8_lr_sc_vm
>> [       OK ] RiscV.cmpxchg_weak_int8_lr_sc_vm (0 ms)
>> [ RUN      ] RiscV.cmpxchg_weak_int16_maybe_zacas_vm
>> [       OK ] RiscV.cmpxchg_weak_int16_maybe_zacas_vm (0 ms)
>> [ RUN      ] RiscV.cmpxchg_weak_int8_maybe_zacas_vm
>> [       OK ] RiscV.cmpxchg_weak_int8_maybe_zacas_vm (0 ms)
>> [----------] 4 tests from RiscV (20997 ms total)
>> 
>> Executed with -XX:+UnlockExperimentalVMOptions -XX:+UseZacas
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed WS

Looks good, thanks for adding the tests.
Just one minor comment.

test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 327:

> 325: }
> 326: 
> 327: TEST_VM(RiscV, cmpxchg_weak_int16_lr_sc) {

I'm not familiar with the gtest syntax in JDK, seems this (`cmpxchg_weak_int16_lr_sc`) is just a name?
But it still good to follow the name convenction, i.e. weak_cmpxchg.

test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 366:

> 364: }
> 365: 
> 366: TEST_VM(RiscV, cmpxchg_weak_int64_lr_sc) {

similar comment here, and below

-------------

PR Review: https://git.openjdk.org/jdk/pull/22476#pullrequestreview-2475152687
PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1867407796
PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1867409382