RFR: 8345179: RISC-V: Add gtests for weak cmpxchg [v5]

Robbin Ehn rehn at openjdk.org
Wed Dec 4 08:21:24 UTC 2024


On Tue, 3 Dec 2024 09:58:43 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed WS
>
> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 327:
> 
>> 325: }
>> 326: 
>> 327: TEST_VM(RiscV, cmpxchg_weak_int16_lr_sc) {
> 
> I'm not familiar with the gtest syntax in JDK, seems this (`cmpxchg_weak_int16_lr_sc`) is just a name?
> But it still good to follow the name convenction, i.e. weak_cmpxchg.

fixed in merge

> test/hotspot/gtest/riscv/test_assembler_riscv.cpp line 366:
> 
>> 364: }
>> 365: 
>> 366: TEST_VM(RiscV, cmpxchg_weak_int64_lr_sc) {
> 
> similar comment here, and below

fixed in merge

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1868929836
PR Review Comment: https://git.openjdk.org/jdk/pull/22476#discussion_r1868930071


More information about the hotspot-dev mailing list