RFR: 8344609: Check ResourceMark nesting when allocating a GrowableArray on an alternative ResourceArea [v3]
David Holmes
dholmes at openjdk.org
Tue Dec 3 23:32:39 UTC 2024
On Mon, 2 Dec 2024 13:42:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> With this change the GrowableArray nesting check is also performed if allocating from an `Arena` which in fact is a `ResourceArea`.
>>
>> The additional checking can help find issue as [JDK-8328085](https://bugs.openjdk.org/browse/JDK-8328085).
>>
>> The fix passed our nightly CI testing:
>> Tier 1-4 of hotspot and jdk. All of langtools and jaxp. Renaissance Suite and SAP specific tests.
>> Testing was done on the main platforms and also on Linux/PPC64le and AIX.
>>
>> Besides ctw tests on ppc64 (see [JDK-8328085](https://bugs.openjdk.org/browse/JDK-8328085)) the check never failed.
>
> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master'
> - Add parentheses
> - Check GrowableArray nesting if allocating on alternative ResourceArea
I ran this through our CI as well - no issues in T1-4
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22269#issuecomment-2515800342
More information about the hotspot-dev
mailing list