RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

[Julian Waters]

On Wed, 4 Dec 2024 01:19:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into hotspot
>>  - Reintroduce ifdef removed in the nuking of the Windows 32 bit x86 port in sharedRuntimeRem.cpp
>>  - fmod_win64 in sharedRuntime.cpp
>>  - Should only declare fmod_win64 on Windows/ARM64 sharedRuntime.hpp
>>  - fmod_win64 in src/hotspot/share/runtime/sharedRuntime.hpp
>>    
>>    Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>>  - No spaces in test_os_windows.cpp
>>  - No spaces in test/hotspot/gtest/runtime/test_os.cpp
>>    
>>    Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>>  - Revise comment in sharedRuntime.hpp
>>  - Revise comment in sharedRuntime.cpp
>>  - size_t brace initialization instead of unsigned literals in test_os_windows.cpp
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/741dd6d5...6cf1c83a
>
> src/hotspot/os/windows/sharedRuntimeRem.cpp line 28:
> 
>> 26: #include "runtime/sharedRuntime.hpp"
>> 27: 
>> 28: #ifdef _M_ARM64
> 
> As this is ARM64 only now, the comment block at line 34 needs updating

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1868698927