RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

[Julian Waters]

On Mon, 9 Dec 2024 09:38:33 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Ah, I see what you mean. There's just a small change I would make, which is to check whether defined(_WINDOWS) and defined(AARCH64) instead. Checking for both _M_ARM64 and _WINDOWS is redundant; _M_ARM64 is a Windows only define, so checking for _M_ARM64 == checking for AARCH64 && _WINDOWS. Would you be ok with that instead?
>> 
>> I think(?) I get what you mean by having 2 blocks, I'll try to do that
>> 
>>> Sorry I'm doing a really bad job of pretending to be the preprocessor. :)
>> 
>> Haha, it happens
>
>> Ah, I see what you mean. There's just a small change I would make, which is to check whether defined(_WINDOWS) and defined(AARCH64) instead. Checking for both _M_ARM64 and _WINDOWS is redundant; _M_ARM64 is a Windows only define, so checking for _M_ARM64 == checking for AARCH64 && _WINDOWS.
> 
> Checking for `AARCH64 && _WINDOWS` is much easier to understand.

Andrew and David, are the latest changes what you had in mind?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1876992308