RFR: 8345314: Add a red–black tree as a utility data structure [v3]

Johan Sjölen jsjolen at openjdk.org
Wed Dec 4 11:58:39 UTC 2024


On Wed, 4 Dec 2024 10:16:55 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> The entire tree is templated, so we can't easily move the implementation to a cpp file
>
> You can, by using explicit template instantiation. That would be an improvement over putting it all in the header file, IMHO.

I'm a bit surprised that it's contentious to have the whole tree in the header file when we do the same with other templated types such as `GrowableArray`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22360#discussion_r1869344185


More information about the hotspot-dev mailing list