RFR: 8345314: Add a red–black tree as a utility data structure [v3]

Casper Norrbin cnorrbin at openjdk.org
Wed Dec 4 12:07:38 UTC 2024


On Wed, 4 Dec 2024 10:16:55 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> The entire tree is templated, so we can't easily move the implementation to a cpp file
>
> You can, by using explicit template instantiation. That would be an improvement over putting it all in the header file, IMHO.

@theRealAph I don't think that would be possible either. We can't possibly know every type combination to instantiate, especially since we're asking users to provide their own comparator and allocator through the template.

And like Johan said, we already have templated header-only structures, like `GrowableArray` and `ConcurrentHashTable`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22360#discussion_r1869362633


More information about the hotspot-dev mailing list