RFR: 8345314: Add a red–black tree as a utility data structure [v3]

David Holmes dholmes at openjdk.org
Thu Dec 5 09:45:41 UTC 2024


On Wed, 4 Dec 2024 13:28:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I think the case for making the whole thing in a header depends on how much code there is, that's all.
>
> concurrentHashTable uses the trick of inlining a lot of methods in concurrentHashTable.inline.hpp and concurrentHashTableTasks.inline.hpp that are included in the .cpp callers.  This might work for this also.

FWIW this was a drive by comment and it just surprised me to see everything in the hpp file. I don't know GrowableArray enough to recognise it has a similar approach.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22360#discussion_r1871011459


More information about the hotspot-dev mailing list