RFR: 8345314: Add a red–black tree as a utility data structure [v3]
Coleen Phillimore
coleenp at openjdk.org
Thu Dec 5 19:02:38 UTC 2024
On Thu, 5 Dec 2024 09:42:45 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> concurrentHashTable uses the trick of inlining a lot of methods in concurrentHashTable.inline.hpp and concurrentHashTableTasks.inline.hpp that are included in the .cpp callers. This might work for this also.
>
> FWIW this was a drive by comment and it just surprised me to see everything in the hpp file. I don't know GrowableArray enough to recognise it has a similar approach.
Also one advantage of putting much of the implementation in the .inline.hpp file is that it's easy to see how to use this if only a small number of lines of code are in the hpp file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22360#discussion_r1871936346
More information about the hotspot-dev
mailing list