RFR: 8342769: HotSpot Windows/gcc port is broken [v9]
Andrew Haley
aph at openjdk.org
Mon Dec 9 09:41:40 UTC 2024
On Mon, 9 Dec 2024 08:24:09 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> Ah, I see what you mean. There's just a small change I would make, which is to check whether defined(_WINDOWS) and defined(AARCH64) instead. Checking for both _M_ARM64 and _WINDOWS is redundant; _M_ARM64 is a Windows only define, so checking for _M_ARM64 == checking for AARCH64 && _WINDOWS.
Checking for `AARCH64 && _WINDOWS` is much easier to understand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1875662049
More information about the hotspot-dev
mailing list