RFR: 8342769: HotSpot Windows/gcc port is broken [v14]

[David Holmes]

On Tue, 10 Dec 2024 00:47:04 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - _WINDOWS && AARCH64 in sharedRuntime.hpp
>  - AARCH64 in sharedRuntimeRem.cpp
>  - Refactor sharedRuntime.cpp

That seems a lot clearer to me now - thanks.

Just one query below.

src/hotspot/os/windows/sharedRuntimeRem.cpp line 28:

> 26: #include "runtime/sharedRuntime.hpp"
> 27: 
> 28: #ifdef AARCH64

Shouldn't this also be

#if defined(_WINDOWS) && defined(AARCH64)

?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21627#pullrequestreview-2490993838
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1877321284